<html>
<head><meta charset="utf-8"><title>rustdoc perf triage · t-compiler/performance · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/index.html">t-compiler/performance</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/rustdoc.20perf.20triage.html">rustdoc perf triage</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="227714935"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/rustdoc%20perf%20triage/near/227714935" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/rustdoc.20perf.20triage.html#227714935">(Feb 25 2021 at 04:09)</a>:</h4>
<p>Do you all triage rustdoc perf as well? There some to be some moderate rustdoc perf improvements over the past week, and I'm curious to know which PRs it was :)</p>



<a name="228151796"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/rustdoc%20perf%20triage/near/228151796" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/rustdoc.20perf.20triage.html#228151796">(Feb 28 2021 at 19:41)</a>:</h4>
<p>bump — I'm assuming the answer is "no"</p>



<a name="228152056"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/rustdoc%20perf%20triage/near/228152056" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/rustdoc.20perf.20triage.html#228152056">(Feb 28 2021 at 19:46)</a>:</h4>
<p>Currently, no, because rustdoc runs are <a href="https://github.com/rust-lang/rustc-perf/blob/115aff9e6ebc72619c6f8c878d812fab9f697d72/triage/weekly_report.py#L158-L160">explicitly omitted</a> from the performance triage reports by the script we use. I am hesitant to add potentially another set of regressions or improvements to the triage plate - it's already a struggle to find people who can do it, and adding another dimension is unlikely to be helpful, but it would be not too hard to edit the script to <em>only</em> include those and for you to run it locally on some commit range.</p>



<a name="228158916"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/rustdoc%20perf%20triage/near/228158916" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Lokathor <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/rustdoc.20perf.20triage.html#228158916">(Feb 28 2021 at 21:39)</a>:</h4>
<p>Yeah if the script had a clear "perf run compiler" and "perf run rustdoc" mode then that might (might) encourage people to investigate rustdoc</p>



<a name="228158975"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/rustdoc%20perf%20triage/near/228158975" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Lokathor <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/rustdoc.20perf.20triage.html#228158975">(Feb 28 2021 at 21:40)</a>:</h4>
<p>though since rustdoc runs on a distant cloud for most people, i'm not sure they'll investigate too much there</p>



<a name="228210935"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/rustdoc%20perf%20triage/near/228210935" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/rustdoc.20perf.20triage.html#228210935">(Mar 01 2021 at 10:54)</a>:</h4>
<p>We are looking into how to improve the process for Rust performance tracking/triage <a href="#narrow/stream/247081-t-compiler.2Fperformance/topic/The.20short-term.20performance.20process.20review">here</a>. We should definitely keep this in mind though as <span class="user-mention" data-user-id="116122">@simulacrum</span> has noted, it's already a struggle to keep up with the base compiler. Hopefully, once we improve our process enough, it can expand to take on more things like rustdoc.</p>



<a name="228347896"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/rustdoc%20perf%20triage/near/228347896" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/rustdoc.20perf.20triage.html#228347896">(Mar 02 2021 at 03:35)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116122">simulacrum</span> <a href="#narrow/stream/247081-t-compiler.2Fperformance/topic/rustdoc.20perf.20triage/near/228152056">said</a>:</p>
<blockquote>
<p>Currently, no, because rustdoc runs are <a href="https://github.com/rust-lang/rustc-perf/blob/115aff9e6ebc72619c6f8c878d812fab9f697d72/triage/weekly_report.py#L158-L160">explicitly omitted</a> from the performance triage reports by the script we use. I am hesitant to add potentially another set of regressions or improvements to the triage plate - it's already a struggle to find people who can do it, and adding another dimension is unlikely to be helpful, but it would be not too hard to edit the script to <em>only</em> include those and for you to run it locally on some commit range.</p>
</blockquote>
<p>Ah, I didn't realize that part of the triage was automated. I'll try out modifying the script, thanks!</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>